Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: actually use -socketevents #6027

Merged
1 commit merged into from
May 18, 2024
Merged

fix: actually use -socketevents #6027

1 commit merged into from
May 18, 2024

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented May 17, 2024

Issue being fixed or feature implemented

#6007 follow-up

What was done?

How Has This Been Tested?

check socketevents in getnetworkinfo response

Breaking Changes

n/a

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@UdjinM6 UdjinM6 added this to the 21 milestone May 17, 2024
@UdjinM6 UdjinM6 requested a review from kwvg May 17, 2024 17:13
kwvg
kwvg approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@kwvg kwvg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 113b3fe

Tested on Debian bookworm with Dash Qt

@UdjinM6 UdjinM6 requested review from knst and PastaPastaPasta May 17, 2024 18:13
PastaPastaPasta
PastaPastaPasta approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 113b3fe

@PastaPastaPasta PastaPastaPasta closed this pull request by merging all changes into dashpay:develop in 8b7f9c8 May 18, 2024
@kwvg kwvg mentioned this pull request May 19, 2024
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

@kwvg kwvg kwvg approved these changes

@knst knst Awaiting requested review from knst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
21
Development

Successfully merging this pull request may close these issues.
3 participants
@UdjinM6 @PastaPastaPasta @kwvg