refactor: backport bitcoin#24356, extend -socketevents to Sock, implement Sock::WaitMany{Epoll, KQueue}

src/i2p.cpp

@@ -162,8 +162,8 @@ bool Session::Accept(Connection& conn)
                 throw std::runtime_error("wait on socket failed");
             }
 
-            if ((occurred & Sock::RECV) == 0) {
-                // Timeout, no incoming connections within MAX_WAIT_FOR_IO.
+            if (occurred == 0) {
+                // Timeout, no incoming connections or errors within MAX_WAIT_FOR_IO.
                 continue;
             }
 
@@ -295,7 +295,7 @@ Session::Reply Session::SendRequestAndGetReply(const Sock& sock,
 
 std::unique_ptr<Sock> Session::Hello() const
 {
-    auto sock = CreateSock(m_control_host);
+    auto sock = CreateSock(m_control_host, SocketEventsMode::Select, /* fd_mode = */ std::nullopt);
 
     if (!sock) {
         throw std::runtime_error("Cannot create socket");

src/masternode/node.cpp

@@ -155,7 +155,7 @@ void CActiveMasternodeManager::InitInternal(const CBlockIndex* pindex)
 
     // Check socket connectivity
     LogPrintf("CActiveMasternodeManager::Init -- Checking inbound connection to '%s'\n", m_info.service.ToStringAddrPort());
-    std::unique_ptr<Sock> sock = CreateSock(m_info.service);
+    std::unique_ptr<Sock> sock = CreateSock(m_info.service, SocketEventsMode::Select, /* fd_mode = */ std::nullopt);
     if (!sock) {
         m_state = MASTERNODE_ERROR;
         m_error = "Could not create socket to connect to " + m_info.service.ToStringAddrPort();