Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: actually run rpc_fundrawtransaction with and without HD feature #5907

Merged
merged 1 commit into from
Mar 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions test/functional/rpc_fundrawtransaction.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,17 +28,16 @@ class RawTransactionsTest(BitcoinTestFramework):
def set_test_params(self):
self.num_nodes = 4
self.setup_clean_chain = True
self.extra_args = [[f'-usehd={self.options.usehd}']] * self.num_nodes
# This test isn't testing tx relay. Set whitelist on the peers for
# instant tx relay.
self.extra_args = [['-whitelist=noban@127.0.0.1']] * self.num_nodes
self.extra_args = [[f'-usehd={not self.options.nohd}', '-whitelist=noban@127.0.0.1']] * self.num_nodes

def skip_test_if_missing_module(self):
self.skip_if_no_wallet()

def add_options(self, parser):
parser.add_argument("--usehd", dest="usehd", default=False, action="store_true",
help="Test with -usehd enabled")
parser.add_argument("--nohd", dest="nohd", default=False, action="store_true",
help="Test with -nohd enabled")

def setup_network(self):
self.setup_nodes()
Expand Down
2 changes: 1 addition & 1 deletion test/functional/test_runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@
'feature_maxuploadtarget.py',
'feature_block.py', # NOTE: needs dash_hash to pass
'rpc_fundrawtransaction.py',
'rpc_fundrawtransaction.py --usehd',
'rpc_fundrawtransaction.py --nohd',
'wallet_multiwallet.py --usecli',
'p2p_quorum_data.py',
# vv Tests less than 2m vv
Expand Down
Loading