V0.12.1.x DS can (potentially) leak info by number of inputs #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduffield222
pushed a commit
that referenced
this pull request
Sep 2, 2015
V0.12.1.x DS can (potentially) leak info by number of inputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When users submit different number of inputs in one mixing session it can potentially leak info by previous txid even if all inputs use the same denomination(s). This is mostly applicable to first few rounds of mixing, the more rounds of mixing is passed the less info is leaked. But anyway, this is still a really bad situation imo.
This PR should fix issue I just described by requiring users to submit not only the same denominations but also exactly the same number of inputs.
Note:
PROTOCOL_VERSIONandMIN_POOL_PEER_PROTO_VERSIONRebase #558