refactor: rename assetLockedAmount in CbTx to creditPoolBalance
#5526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce` Bad naming is noticed in dashpay#5026 by thephez
5 tasks
PastaPastaPasta
approved these changes
Aug 8, 2023
This was referenced Aug 8, 2023
knst
added a commit
to knst/dash
that referenced
this pull request
Aug 24, 2023
…ashpay#5526) ## Issue being fixed or feature implemented Bad naming is noticed in dashpay#5026 by thephez ## What was done? Renamed `assetLockedAmount` in CbTx to `creditPoolBalance` Renamed also some local variables and functions to make it matched also. ## How Has This Been Tested? Run functional/unit tests - succeed Called python's rpc binding `node.getblock(block_hash)['cbTx']`: Got this result: ``` {'version': 3, 'height': 1556, 'merkleRootMNList': '978b2b4d1b884de62799b9eaee75c7812fea59f98f80d5ff9c963b0f0f195e14', 'merkleRootQuorums': 'bc7a34eb114f4e4bf38a11080b5d8ac41bdb36dd41e17467bae23c94ba06b013', 'bestCLHeightDiff': 0, 'bestCLSignature': '000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000', 'creditPoolBalance': Decimal('7.00141421')} ``` ## Breaking Changes Renamed `assetLockedAmount` in CbTx to `creditPoolBalance`. @shumkov be informed ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [x] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Bad naming is noticed in #5026 by thephez
What was done?
Renamed
assetLockedAmountin CbTx tocreditPoolBalanceRenamed also some local variables and functions to make it matched also.
How Has This Been Tested?
Run functional/unit tests - succeed
Called python's rpc binding
node.getblock(block_hash)['cbTx']:Got this result:
Breaking Changes
Renamed
assetLockedAmountin CbTx tocreditPoolBalance. @shumkov be informedChecklist: