Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -DDEBUG_LOCKORDER from debug configuration #1010

Merged
merged 2 commits into from
Sep 12, 2016
Merged

Remove -DDEBUG_LOCKORDER from debug configuration #1010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6afdbbd
Remove -DDEBUG_LOCKORDER from debug configuration
tgflynn Sep 11, 2016
7b499cb
Updated documentation to reflect removal of -DDEBUG_LOCKORDER from de…
tgflynn Sep 12, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ AC_ARG_ENABLE([debug],
[enable_debug=no])

if test "x$enable_debug" = xyes; then
CPPFLAGS="$CPPFLAGS -DDEBUG -DDEBUG_LOCKORDER"
CPPFLAGS="$CPPFLAGS -DDEBUG"
if test "x$GCC" = xyes; then
CFLAGS="$CFLAGS -g3 -O0"
fi
Expand Down
3 changes: 1 addition & 2 deletions doc/developer-notes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,8 +329,7 @@ Threads and synchronization
----------------------------

- Build and run tests with `-DDEBUG_LOCKORDER` to verify that no potential
deadlocks are introduced. As of 0.12, this is defined by default when
configuring with `--enable-debug`
deadlocks are introduced.

- When using `LOCK`/`TRY_LOCK` be aware that the lock exists in the context of
the current scope, so surround the statement and the code that needs the lock
Expand Down