Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inputs per denomination in GUI not honoured #5975

Closed
p-m opened this issue Apr 8, 2024 · 3 comments · Fixed by #6208
Closed

Inputs per denomination in GUI not honoured #5975

p-m opened this issue Apr 8, 2024 · 3 comments · Fixed by #6208

Comments

@p-m
Copy link

p-m commented Apr 8, 2024

Hi,

When setting non default values for denoms_goal and denoms_hardcap in GUI, dash-qt still uses default values.

Steps to reproduce:
1.) Fresh installation of dashcore-20.1.1-x86_64-linux-gnu.tar.gz (no configuration files)
2.) Start dash-qt
3.) Set "Inputs per denomination" to Target = 10, Maximum = 16
4.) Check used values in console with getcoinjoininfo: 10/16, this is ok.
5.) Restart dash-qt
6.) Check values in GUI: 10/16, this is ok
7.) Check used values in console with getcoinjoininfo: 50/300, this is NOT ok.

Workaround: Set values in ~/.dashcore/dash.conf.

Cheers, Peter
@kxcd
Copy link

kxcd commented Aug 12, 2024

More than one user reporting this issue. Can a dev have a look into it and see if you can reproduce and maybe suggest a fix?

@PastaPastaPasta
Copy link
Member

More than one user reporting this issue.

Can you cite the others?

@PastaPastaPasta PastaPastaPasta mentioned this issue Aug 13, 2024
Merged
5 tasks
@PastaPastaPasta
Copy link
Member

Resolved in #6208; will be released in v22 / v21.2 / v21.1.1 whichever comes first :)

PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Oct 22, 2024
@PastaPastaPasta
Merge dashpay#6208: fix: persist coinjoin denoms options from gui ove…
a4e6b8a 
…r restarts

3ec0c8c fix: persist coinjoin denoms and sessions options from gui over restarts (pasta)

Pull request description:

  ## Issue being fixed or feature implemented
  Persist coinjoin denoms over restarts, fixes dashpay#5975

  ## What was done?
  Soft set the argument into the daemon from GUI settings

  ## How Has This Been Tested?
  follow procedure in 5975

  ## Breaking Changes

  ## Checklist:
    _Go over all the following points, and put an `x` in all the boxes that apply._
  - [ ] I have performed a self-review of my own code
  - [ ] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [ ] I have made corresponding changes to the documentation
  - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_

ACKs for top commit:
  knst:
    utACK 3ec0c8c
  UdjinM6:
    utACK 3ec0c8c

Tree-SHA512: b7378460b3990713b755f36de506b94e7d0005f19cf1155f2fc12191ba03f2e16c35049ddbd89f578acd89bc8eae5e432913114e1ff5ef7ab2cc30628aeff3f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: persist coinjoin denoms options from gui over restarts PastaPastaPasta/dash
3 participants
@p-m @PastaPastaPasta @kxcd