Skip to content

Commit

Permalink
fix: skip functional tests which requires BDB if no bdb (see 20267)
Browse files Browse the repository at this point in the history
Skipped tests:
 - feature_filelock
 - wallet_descriptors
 - interface_bitcoin_cli
And all functional tests which explitely specify they are using non-descriptor wallets
  • Loading branch information
knst committed Mar 6, 2024
1 parent 4ba44fa commit da8e563
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 0 deletions.
4 changes: 4 additions & 0 deletions test/functional/feature_filelock.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ def set_test_params(self):
self.setup_clean_chain = True
self.num_nodes = 2

# TODO: remove it after 20267 done
def skip_test_if_missing_module(self):
self.skip_if_no_bdb()

def setup_network(self):
self.add_nodes(self.num_nodes, extra_args=None)
self.nodes[0].start()
Expand Down
2 changes: 2 additions & 0 deletions test/functional/interface_bitcoin_cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ def set_test_params(self):

def skip_test_if_missing_module(self):
self.skip_if_no_cli()
# TODO: drop it when bitcoin#20267 is done
self.skip_if_no_bdb()

def run_test(self):
"""Main test logic"""
Expand Down
2 changes: 2 additions & 0 deletions test/functional/test_framework/test_framework.py
Original file line number Diff line number Diff line change
Expand Up @@ -952,6 +952,8 @@ def skip_if_no_wallet(self):
raise SkipTest("wallet has not been compiled.")
if self.options.descriptors:
self.skip_if_no_sqlite()
else:
self.skip_if_no_bdb()

def skip_if_no_sqlite(self):
"""Skip the running test if sqlite has not been compiled."""
Expand Down
2 changes: 2 additions & 0 deletions test/functional/wallet_descriptor.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ def set_test_params(self):

def skip_test_if_missing_module(self):
self.skip_if_no_wallet()
# TODO: drop it when bitcoin#20267 is done
self.skip_if_no_bdb()
self.skip_if_no_sqlite()

def run_test(self):
Expand Down

0 comments on commit da8e563

Please sign in to comment.