This repository has been archived by the owner on Dec 16, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shumkov
reviewed
Dec 9, 2020
shumkov
reviewed
Dec 9, 2020
shumkov
reviewed
Dec 9, 2020
shumkov
reviewed
Dec 17, 2020
shumkov
reviewed
Dec 21, 2020
Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
shumkov
approved these changes
Dec 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store version of package.json used to create a config, and check that version against current package.json version during config validation.
Issue being fixed or feature implemented
This means it will no longer be necessary to drop config and start again when new versions are released.
What was done?
Added a version to the config file schema and constructor, and check that version against the current package.json version to allow for transformations (yet to be defined) to the config as new settings are added.
How Has This Been Tested?
Tested in debugger and by looking at the generated file. Validation works and the conditional code is triggered.
Breaking Changes
Checklist:
For repository code-owners and collaborators only