Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

feat: config versions #199

Merged
merged 9 commits into from
Dec 22, 2020
Merged

feat: config versions #199

merged 9 commits into from
Dec 22, 2020

Conversation

strophy
Copy link
Contributor

@strophy strophy commented Dec 8, 2020

Store version of package.json used to create a config, and check that version against current package.json version during config validation.

Issue being fixed or feature implemented

This means it will no longer be necessary to drop config and start again when new versions are released.

What was done?

Added a version to the config file schema and constructor, and check that version against the current package.json version to allow for transformations (yet to be defined) to the config as new settings are added.

How Has This Been Tested?

Tested in debugger and by looking at the generated file. Validation works and the conditional code is triggered.

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v0.17 milestone Dec 17, 2020
@strophy strophy marked this pull request as ready for review December 21, 2020 08:27
Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍

@shumkov shumkov merged commit ce15f24 into dashevo:v0.17-dev Dec 22, 2020
@shumkov shumkov deleted the config-versions branch December 22, 2020 11:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants