#5 Incompatible with Gradle Version 9 - Upgrade react native 72 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgraded example to RN v0.72.4 using https://react-native-community.github.io/upgrade-helper/?from=0.63.5&to=0.72.4
Upgraded example to RN v0.72.4 using https://react-native-community.github.io/upgrade-helper/?from=0.63.5&to=0.72.4
Delete package-lock.json and use yarn to test
asadwan
reviewed
Aug 23, 2023
package.json
Outdated
| @@ -50,11 +50,11 @@ | |||
| "react-native": "*" | |||
| }, | |||
| "devDependencies": { | |||
| "@types/react-native": "^0.63.37", | |||
| "@types/react-native": "^0.72.2", | |||
There was a problem hiding this comment.
Starting from RN 71, types are built-in. You can remove this dep
There was a problem hiding this comment.
Should be removed now, also from example app.
|
Hi R4DIC4L, thanks for the PR. |
|
Any ETA for when this can be available in a future npm release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixed #5 where the lastest gradle version is not supported because of below error.
I have upgraded both react-native-system-sounds and the example to use react-native v0.72.4. I have used upgrade helper to aid me with the upgrade: https://react-native-community.github.io/upgrade-helper/?from=0.63.5&to=0.72.4.
I have tested the android application using the example app and yarn as instructed in the README. I confirm that the sounds are working.
I don't have an iOS device available at the moment, but will have one to test this also on iOS in the following days. Any help to test this on iOS would also be appreciated.
Can you take a look at this PR?