Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenGov to Darwinia #1372

Merged
merged 3 commits into from
Jan 3, 2024
Merged

Add OpenGov to Darwinia #1372

merged 3 commits into from
Jan 3, 2024

Conversation

aurexav
Copy link
Member

@aurexav aurexav commented Dec 28, 2023

No description provided.

@aurexav aurexav added N-Darwinia S-Need Audit PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Dec 28, 2023
@boundless-forest boundless-forest self-requested a review December 29, 2023 02:05
@boundless-forest
Copy link
Member

@AurevoirXavier Please update the branch to pass CI

Copy link

github-actions bot commented Jan 2, 2024

Check 1b6192e pangoro-dev

Check runtime version

Check runtime storage

Copy link

github-actions bot commented Jan 2, 2024

Check 1b6192e crab-dev

Check runtime version

RuntimeVersion {
    spec_name: "Crab2",
    impl_name: "DarwiniaOfficialRust",
    authoring_version: 0,
-   spec_version: 6511,
+   spec_version: 6510,
    impl_version: 0,
    transaction_version: 0,
    state_version: 0,
}

Check runtime storage

- Pallet: "EcdsaAuthority"
- Pallet: "MessageGadget"

Copy link

github-actions bot commented Jan 2, 2024

Check 1b6192e darwinia-dev

Check runtime version

RuntimeVersion {
    spec_name: "Darwinia2",
    impl_name: "DarwiniaOfficialRust",
    authoring_version: 0,
-   spec_version: 6501,
+   spec_version: 6510,
    impl_version: 0,
    transaction_version: 0,
    state_version: 0,
}

Check runtime storage

+ Pallet: "ConvictionVoting"
- Pallet: "PhragmenElection"
+ Pallet: "Referenda"
- Pallet: "TechnicalMembership"
+ Pallet: "Whitelist"

Copy link

github-actions bot commented Jan 2, 2024

Check 1b6192e pangolin-dev

Check runtime version

Check runtime storage

Copy link
Member

@boundless-forest boundless-forest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Lacking the support for the evm, I'll raise a PR after this merge.

@aurexav aurexav merged commit 453b195 into main Jan 3, 2024
12 checks passed
@aurexav aurexav deleted the xavier/gov branch January 3, 2024 02:27
@aurexav aurexav added S-Audited [Security] Audited and removed S-Need Audit PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-Audited [Security] Audited
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants