Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust GasLimitPovSizeRatio #1274

Merged
merged 6 commits into from
Sep 20, 2023
Merged

Adjust GasLimitPovSizeRatio #1274

merged 6 commits into from
Sep 20, 2023

Conversation

boundless-forest
Copy link
Member

@boundless-forest boundless-forest commented Sep 19, 2023 •
edited
Loading

Adjust the ratio to fix the issue that transactions with gas limit over 1200w will be seen as exhausted resource ones. The test I wrote can help reviewer sort it out.

@boundless-forest boundless-forest marked this pull request as ready for review September 19, 2023 13:47
@aurexav
Copy link
Member

aurexav commented Sep 19, 2023

https://github.com/moonbeam-foundation/moonbeam/blob/edf78c382d0049600459443afcae1ecb4e66182c/runtime/moonbeam/src/lib.rs#L402-L407

@aurexav
Copy link
Member

aurexav commented Sep 19, 2023

20000000 / 5 / 1024 / 1024 + 1 = 4

aurexav
aurexav previously approved these changes Sep 19, 2023
View reviewed changes
@aurexav aurexav added S-Patch B-Runtime [Bug] Some mistakes with the runtime logic labels Sep 19, 2023
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
hackfisher
hackfisher reviewed Sep 19, 2023
View reviewed changes
Copy link
Contributor

@hackfisher hackfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but some other test check failed.

And remember the runtime is a patch to be provided based on v6.4.0

@github-actions
Copy link

Check ce4fafe darwinia-dev

Check runtime version





Check runtime storage








      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    














        

  
      



  

  @github-actions





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  


  

    

  





      


        


  
    

      
          

Check ce4fafe pangoro-dev



Check runtime version








Check runtime storage








      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












        

  
      



  

  @github-actions





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  


  

    

  





      


        


  
    

      
          

Check ce4fafe crab-dev



Check runtime version








Check runtime storage








      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












        

  
      



  

  @github-actions





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  


  

    

  





      


        


  
    

      
          

Check ce4fafe pangolin-dev



Check runtime version








Check runtime storage








      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












        

  
          

  

    
  

  



        @aurexav
  aurexav



        merged commit 96d48b9
      into

      
  
    main
  


    Sep 20, 2023

  







  

  
  

  
      @aurexav
  aurexav


    
    deleted the
    
      
        bear-adjust-proof-size-ratio
    
    branch

    September 20, 2023 02:48    
    




  


  
    
  
  

    
  aurexav 

      pushed a commit
      that referenced
      this pull request

    
      Sep 20, 2023
    
    

      


  

    

      


  

      
        @boundless-forest
      
        @aurexav
  





      

        
          Adjust GasLimitPovSizeRatio (#1274)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

      


      
      

        
          fc6b7fe
        
      

    

  

    

      
* Try fix

* Better

* Add automate test

* Apply the changes to other networks

* Update comment

* Fix ts test

    




    

  




  


  
    
  
  

    
  aurexav 

      added a commit
      that referenced
      this pull request

    
      Sep 20, 2023
    
    

      


  

    

      


  

      
        @aurexav
      
        @boundless-forest
  





      

        
          Release v6.4.0-1 (#1277)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

      


      
      

        
          b874775
        
      

    

  

    

      
* Adjust `GasLimitPovSizeRatio` (#1274)

* Try fix

* Better

* Add automate test

* Apply the changes to other networks

* Update comment

* Fix ts test

* Release `v6.4.0-1`

* Clear

---------

Co-authored-by: Bear Wang <boundless.forest@outlook.com>

    




    

  











  
  

    

      

  




    


    

      

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
          




      

  

    
    

    
  

    Reviewers
  


    


        

          

  
      @hackfisher
  
    hackfisher



          
            
              
            
          
          hackfisher left review comments

        

        

          

  
      @aurexav
  
    aurexav



          
            
              
            
          
          aurexav left review comments

        


      






    

  


      
  

    Assignees
  



        

      

        

  
      @boundless-forest
  
    boundless-forest
    

      








      


  


  

    Labels
  



    

      

    B-Runtime

  [Bug] Some mistakes with the runtime logic








      

  

    

        

    Projects
  


        




        
  

    

      
          
        Darwinia Chain
        
    

    

      

            
    Status: Done

              
      

    

    

  







  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  



          


Successfully merging this pull request may close these issues.



  


    
  




      

    

  
      

  

    

      3 participants
    

    

        
          @boundless-forest 
        
          @aurexav 
        
          @hackfisher