Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Companion for #250 #501

Closed
aurexav opened this issue Aug 27, 2020 · 0 comments · Fixed by #505
Closed

Companion for #250 #501

aurexav opened this issue Aug 27, 2020 · 0 comments · Fixed by #505
Assignees
@aurexav

Comments

@aurexav
Copy link
Member

aurexav commented Aug 27, 2020

darwinia-network/darwinia-common#250
@aurexav aurexav self-assigned this Aug 27, 2020
@aurexav aurexav linked a pull request Aug 28, 2020 that will close this issue
Companion for #250 #505
Merged
@aurexav aurexav closed this as completed Aug 28, 2020
boundless-forest pushed a commit that referenced this issue Aug 1, 2023
@zjb0807
fix estimate-gas (#501)
1a67bc5
boundless-forest pushed a commit that referenced this issue Aug 1, 2023
@librelois @zjb0807
estimateGas: if the first execution revert, it's not an exceeds allow…
4dafbaf 
…ance (#503)

* Revert "fix estimate-gas (#501)"

This reverts commit 1a67bc5.

* estimate: if the first exec revert, verify if it's really a lack of gas

Co-authored-by: zjb0807 <zjb0807@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aurexav aurexav

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Companion for #250 darwinia-network/darwinia
1 participant
@aurexav