Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port clang warning fix over to 6.4 #964

Merged
merged 2 commits into from
Feb 1, 2018
Merged

Conversation

mxgrey
Copy link
Member

@mxgrey mxgrey commented Jan 31, 2018

Same as #963, but targeting release-6.4

@mxgrey mxgrey added the type: bug Indicates an unexpected problem or unintended behavior label Jan 31, 2018
@mxgrey mxgrey added this to the DART 6.4.0 milestone Jan 31, 2018
Copy link
Member

@jslee02 jslee02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides updating the changelog, it looks good to me! 👍

@codecov
Copy link

codecov bot commented Feb 1, 2018

Codecov Report

Merging #964 into release-6.4 will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           release-6.4     #964   +/-   ##
============================================
  Coverage        56.64%   56.64%           
============================================
  Files              310      310           
  Lines            23923    23923           
============================================
  Hits             13550    13550           
  Misses           10373    10373
Impacted Files Coverage Δ
dart/common/detail/CompositeData.hpp 98.14% <ø> (ø) ⬆️

@jslee02 jslee02 merged commit fec4c24 into release-6.4 Feb 1, 2018
@jslee02 jslee02 deleted the grey/satisfy_clang5_6.4 branch February 1, 2018 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants