Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy evaluation for shape volume and bounding-box #959

Merged
merged 6 commits into from
Jan 19, 2018

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Jan 18, 2018

resolves #734


Before creating a pull request

  • Document new methods and classes

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.4.0 milestone Jan 18, 2018
@codecov
Copy link

codecov bot commented Jan 19, 2018

Codecov Report

Merging #959 into release-6.4 will decrease coverage by 0.37%.
The diff coverage is 19.53%.

@@              Coverage Diff               @@
##           release-6.4    #959      +/-   ##
==============================================
- Coverage        56.87%   56.5%   -0.38%     
==============================================
  Files              310     310              
  Lines            23883   23915      +32     
==============================================
- Hits             13584   13512      -72     
- Misses           10299   10403     +104
Impacted Files Coverage Δ
dart/dynamics/LineSegmentShape.hpp 0% <ø> (ø) ⬆️
dart/dynamics/CylinderShape.hpp 100% <ø> (ø) ⬆️
dart/dynamics/CapsuleShape.hpp 100% <ø> (ø) ⬆️
dart/dynamics/PlaneShape.hpp 0% <ø> (ø) ⬆️
dart/dynamics/ConeShape.hpp 100% <ø> (ø) ⬆️
dart/dynamics/ArrowShape.cpp 0% <0%> (ø) ⬆️
dart/dynamics/SoftMeshShape.cpp 83.33% <0%> (-4.91%) ⬇️
dart/dynamics/PlaneShape.cpp 8.33% <0%> (-1.35%) ⬇️
dart/dynamics/ConeShape.cpp 42.5% <15.38%> (-23.36%) ⬇️
dart/dynamics/CapsuleShape.cpp 57.44% <15.38%> (-21.72%) ⬇️
... and 15 more

@jslee02 jslee02 merged commit d22fde0 into release-6.4 Jan 19, 2018
@jslee02 jslee02 deleted the 6.4/enhancement/lazy_evaluation_for_volume_bbox branch January 19, 2018 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants