Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress -Wdangling-else warnings #937

Merged
merged 3 commits into from
Nov 10, 2017
Merged

Suppress -Wdangling-else warnings #937

merged 3 commits into from
Nov 10, 2017

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Nov 10, 2017

GCC 7.2.0 prints warnings of -Wdangling-else. It seems this is because if-statements with a single line macro is prone to dangling else. This PR suppresses these warnings by adding explicit braces around the single line of the macro.


Before creating a pull request

  • Document new methods and classes (N/A)

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change (N/A)

@jslee02 jslee02 added this to the DART 6.4.0 milestone Nov 10, 2017
@jslee02 jslee02 changed the base branch from master to release-6.4 November 10, 2017 14:23
@jslee02
Copy link
Member Author

jslee02 commented Nov 11, 2017

Thanks for the review @mxgrey!

@jslee02 jslee02 deleted the dangling_else branch November 11, 2017 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants