Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid collision checking between objects from the same body node #894

Merged
merged 5 commits into from
Jul 24, 2017

Conversation

pchorak
Copy link
Contributor

@pchorak pchorak commented Jul 20, 2017

I noticed that if I create multiple collision objects for a single link in Gazebo while using DART physics, they are collision checked against each other even though they are part of the same link (body node). The proposed change to CollisionFilter::needCollision prevents collision checking between shapes attached to the same body node.

See collisions.world for an example in Gazebo. It contains a model with two links and self-collisions enabled. The top link consists of two flush collision meshes. Without the change, contacts points (blue dots) are detected between the flush meshes.
before

With the change, no such contacts are detected.
after

@codecov
Copy link

codecov bot commented Jul 21, 2017

Codecov Report

Merging #894 into master will increase coverage by 0.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master     #894      +/-   ##
==========================================
+ Coverage   50.61%   50.63%   +0.01%     
==========================================
  Files         299      299              
  Lines       23409    23411       +2     
  Branches     3015     3016       +1     
==========================================
+ Hits        11849    11854       +5     
+ Misses      10230    10226       -4     
- Partials     1330     1331       +1
Impacted Files Coverage Δ
dart/collision/CollisionFilter.cpp 51.85% <50%> (-0.15%) ⬇️
dart/dynamics/ShapeNode.cpp 58.62% <0%> (+6.89%) ⬆️

@jslee02 jslee02 requested review from mxgrey and jslee02 July 22, 2017 11:56
@jslee02 jslee02 added this to the DART 6.2.1 milestone Jul 22, 2017
@mxgrey mxgrey merged commit 38fdd58 into dartsim:master Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants