Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read joint friction from URDF #891

Merged
merged 2 commits into from
Jun 12, 2017
Merged

Read joint friction from URDF #891

merged 2 commits into from
Jun 12, 2017

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Jun 12, 2017

This PR fixes the URDF parser to read joint friction.

Resolves #890.

@jslee02 jslee02 added this to the DART 6.3.0 milestone Jun 12, 2017
@codecov
Copy link

codecov bot commented Jun 12, 2017

Codecov Report

Merging #891 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #891      +/-   ##
==========================================
+ Coverage   50.59%   50.61%   +0.02%     
==========================================
  Files         299      299              
  Lines       23408    23409       +1     
  Branches     3015     3015              
==========================================
+ Hits        11843    11849       +6     
+ Misses      10236    10230       -6     
- Partials     1329     1330       +1
Impacted Files Coverage Δ
dart/utils/SkelParser.cpp 57.45% <ø> (ø) ⬆️
dart/utils/urdf/DartLoader.cpp 60.74% <100%> (+2.23%) ⬆️

@jslee02 jslee02 merged commit b05200c into master Jun 12, 2017
@jslee02 jslee02 deleted the feature/read_joint_friction branch July 19, 2017 02:42
@jslee02 jslee02 modified the milestones: DART 6.2.1, DART 6.3.0 Aug 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URDF joint friction not read into models
1 participant