Support for Bullet built with double precision (backport #660) #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bullet requires a pre-processor variable to be set before including any headers to determine whether the library was built with single or double precision. Failing to do so may result in a linking error. This commit: 1. Forces CMake to use CONFIG mode (BulletConfig.cmake shipped with bullet) instead of MODULE mode (FindBullet.cmake shipped with CMake by default) in find_package(Bullet). 2. Updates references to BULLET_INCLUDE_DIRS and BULLET_LIBRARIES accordingly 3. Test whether Bullet was built using double precision floating point numbers by attempting to compile code that produces a linking error when the necessary preprocessor definition is missing. 4. Set the necessary preprocessor definition in config.h. combined with commits that Reverted to using Bullet MODULE mode. and Minor output message update for consistency Backport of #660 to release-5.1 branch. Closes #776.
|
👍 LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I squashed the three commits of #660 and applied them to the
release-5.1branch. Closes #776.Bullet requires a pre-processor variable to be set before including any
headers to determine whether the library was built with single or double
precision. Failing to do so may result in a linking error.
This commit:
bullet) instead of MODULE mode (FindBullet.cmake shipped with CMake
by default) in find_package(Bullet).
accordingly
numbers by attempting to compile code that produces a linking error
when the necessary preprocessor definition is missing.
combined with commits that
Reverted to using Bullet MODULE mode.
and
Minor output message update for consistency
This change is