Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update total mass when removing bodies #731

Merged
merged 2 commits into from
Jun 1, 2016
Merged

Update total mass when removing bodies #731

merged 2 commits into from
Jun 1, 2016

Conversation

mxgrey
Copy link
Member

@mxgrey mxgrey commented May 31, 2016

The total mass of a Skeleton was not getting updated when a body is removed. This fixes the problem and introduces a regression test for it.


This change is Reviewable

@jslee02
Copy link
Member

jslee02 commented May 31, 2016

:lgtm:

Previously, mxgrey (Michael X. Grey) wrote…

Update total mass when removing bodies

The total mass of a Skeleton was not getting updated when a body is removed. This fixes the problem and introduces a regression test for it.


Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@jslee02 jslee02 added this to the DART 6.0.1 milestone Jun 1, 2016
@jslee02 jslee02 merged commit d6e2d3d into master Jun 1, 2016
@mxgrey mxgrey deleted the grey/fix_mass branch June 1, 2016 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants