Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing the requirement that Aspects are created within Composites #713

Merged
merged 1 commit into from
May 4, 2016
Merged

Removing the requirement that Aspects are created within Composites #713

merged 1 commit into from
May 4, 2016

Conversation

mxgrey
Copy link
Member

@mxgrey mxgrey commented May 4, 2016 •
edited by jslee02
Loading

This addresses #712 and lifts the arbitrary requirement that every Aspect be created within a Composite.

This change is Reviewable

@jslee02
Copy link
Member

jslee02 commented May 4, 2016

:lgtm:

Reviewed 15 of 15 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@jslee02 jslee02 added this to the DART 6.0.0 milestone May 4, 2016
@mxgrey mxgrey mentioned this pull request May 4, 2016
Closed
@jslee02 jslee02 merged commit 3adc238 into master May 4, 2016
@mxgrey mxgrey deleted the grey/no_composites branch May 4, 2016 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
DART 6.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mxgrey @jslee02