Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ConstraintSolver to return CollisionDetector/CollisionGroup as shared pointer #689

Merged
merged 2 commits into from
Apr 26, 2016
Merged

Make ConstraintSolver to return CollisionDetector/CollisionGroup as shared pointer #689

merged 2 commits into from
Apr 26, 2016

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Apr 22, 2016

This change is Reviewable

@jslee02 jslee02 added this to the DART 6.0.0 milestone Apr 22, 2016
@mxgrey
Copy link
Member

mxgrey commented Apr 25, 2016

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

dart/constraint/ConstraintSolver.cpp, line 230 [r1] (raw file):
If we're ignoring the nullptr argument that we've been given, shouldn't we also return; here?

Comments from Reviewable

@jslee02
Copy link
Member Author

jslee02 commented Apr 25, 2016

Review status: 1 of 2 files reviewed at latest revision, 1 unresolved discussion.

dart/constraint/ConstraintSolver.cpp, line 230 [r1] (raw file):
You're right. Done!

Comments from Reviewable

@jslee02 jslee02 merged commit 579cb2e into master Apr 26, 2016
@jslee02 jslee02 deleted the js/return_shared_collision_detector branch April 26, 2016 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
DART 6.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jslee02 @mxgrey