Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate draw functions of classes in dynamics namespace #654

Merged
merged 3 commits into from
Apr 3, 2016
Merged

Deprecate draw functions of classes in dynamics namespace #654

merged 3 commits into from
Apr 3, 2016

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Mar 30, 2016

No description provided.

@jslee02 jslee02 added this to the DART 6.0.0 milestone Mar 30, 2016
@jslee02
Copy link
Member Author

jslee02 commented Apr 3, 2016

If there is no objection, I'd like to remove draw functions instead of deprecating so that dynamics has no dependency on renderer anymore.

@mxgrey
Copy link
Member

mxgrey commented Apr 3, 2016

I think removing is fine. I don't really view the draw functions as being part of the public API anyway.

@jslee02
Copy link
Member Author

jslee02 commented Apr 3, 2016

draw functions are now removed by @deffdcd.

I believe this PR is ready to merge unless others have more comments on this.

@jslee02 jslee02 merged commit 896a678 into master Apr 3, 2016
@jslee02 jslee02 deleted the deprecate_draw_from_dynamics branch April 4, 2016 00:38
@jslee02 jslee02 restored the deprecate_draw_from_dynamics branch March 10, 2017 19:59
@jslee02 jslee02 deleted the deprecate_draw_from_dynamics branch March 10, 2017 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
DART 6.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jslee02 @mxgrey