Fix FCL version check logic in the main CMakeLists.txt #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| endif() | ||
| endif() | ||
| else() | ||
| if(FCL_VERSION) |
There was a problem hiding this comment.
This check will never be satisfied. According to the find_package documentation, the output variables are only set if a matching version is found (emphasis mine):
These variables are checked by the
find_packagecommand to determine whether the configuration file provides an acceptable version. They are not available after the find_package call returns. If the version is acceptable the following variables are set: [...]
|
Changes Unknown when pulling 3204328 on fix_fcl_version_check into * on master*. |
|
Changes Unknown when pulling 3204328 on fix_fcl_version_check into * on master*. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the FCL version check logic that was introduced by #635.