Add make_unique function omitted from C++11 #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function can be replace by the standard std::make_unique<T>(...) when we migrate to using C++14.
Conflicts: CMakeLists.txt
| // an oversight". This can be replaced by std::make_unique<T> of the standard | ||
| // library when we migrate to using C++14. | ||
|
|
||
| } // namespace std |
There was a problem hiding this comment.
It is undefined to add declarations or definitions to the std namespace:
[C++11: 17.6.4.2.1/1]:The behavior of a C++ program is undefined if it adds declarations or definitions to namespacestdor to a namespace within namespacestdunless otherwise specified. A program may add a template specialization for any standard library template to namespacestdonly if the declaration depends on a user-defined type and the specialization meets the standard library requirements for the original template and is not explicitly prohibited.
There was a problem hiding this comment.
This makes sense. Thanks!
> [C++11: 17.6.4.2.1/1]: The behavior of a C++ program is undefined if it adds declarations or definitions to namespace std or to a namespace within namespace std unless otherwise specified. A program may add a template specialization for any standard library template to namespace std only if the declaration depends on a user-defined type and the specialization meets the standard library requirements for the original template and is not explicitly prohibited. Thanks to @mkoval for pointing this out
|
These changes look good to me 👍 |
jslee02
added a commit
that referenced
this pull request
Mar 21, 2016
Add make_unique function omitted from C++11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds
make_uniquefunction as suggested in #633 .