-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change namespace and directory of osgKido #588
Merged
jslee02
merged 10 commits into
package_reorganizing
from
package_reorganizing_osgKido_rename
Jan 21, 2016
Merged
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
eebbe36
Move osgKido directory under kido/gui with renamed to osg
jslee02 70abb5d
Add open-scene-graph and remove gtest in the dependency list of befor…
jslee02 17d9fee
Change osgKido namespace to kido::gui
jslee02 cefd85a
Update debian meta files for kido-gui-osg
jslee02 dcc849c
Add todo comment on KIDO_BUILD_OSGKIDO cmake option
jslee02 f36f21e
Update todo comment on cmake build options for extension libraries (#…
jslee02 4a7ed50
Update debian package name for kido-gui-osg
jslee02 adf210f
Use kido::gui::osg namespace for osg gui
jslee02 0476bc7
Update header guards of for new namespace kido::gui::osg
jslee02 69ea914
Fix header guards style in gui::osg::render
jslee02 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
usr/include/osgKido/* | ||
usr/lib/libosgKido.so | ||
usr/include/kido/gui/osg/* | ||
usr/lib/libkido-gui-osg.so |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
usr/lib/libosgKido.so.* | ||
usr/lib/libkido-gui-osg.so.* |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
include_directories(SYSTEM ${OPENSCENEGRAPH_INCLUDE_DIRS}) | ||
|
||
# Search all header and source files | ||
file(GLOB srcs "*.cpp") | ||
file(GLOB hdrs "*.hpp") | ||
|
||
set(kido_gui_osg_srcs ${srcs}) | ||
set(kido_gui_osg_hdrs ${hdrs}) | ||
|
||
add_subdirectory(render) | ||
|
||
# Library | ||
kido_add_library(kido-gui-osg ${kido_gui_osg_srcs} ${kido_gui_osg_hdrs}) | ||
target_link_libraries(kido-gui-osg kido kido-utils ${OPENSCENEGRAPH_LIBRARIES}) | ||
|
||
# Generate header for this namespace | ||
kido_get_filename_components(header_names "gui osg headers" ${hdrs}) | ||
list(APPEND header_names "render/render.hpp") | ||
kido_generate_include_header_list( | ||
gui_osg_headers | ||
"kido/gui/osg/" | ||
"gui osg headers" | ||
${header_names} | ||
) | ||
configure_file( | ||
${CMAKE_CURRENT_SOURCE_DIR}/osg.hpp.in | ||
${CMAKE_CURRENT_BINARY_DIR}/osg.hpp | ||
) | ||
|
||
if(${KIDO_BUILD_EXAMPLES}) | ||
add_subdirectory(examples) | ||
endif(${KIDO_BUILD_EXAMPLES}) | ||
|
||
# Install | ||
install( | ||
FILES ${hdrs} ${CMAKE_CURRENT_BINARY_DIR}/osg.hpp | ||
DESTINATION include/kido/gui/osg | ||
COMPONENT headers | ||
) | ||
install(TARGETS kido-gui-osg EXPORT KIDOTargets DESTINATION lib) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually do think we should have an option flag for each extension, although I don't consider that to be high priority.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, as KIDO 0.1.0 should be released as soon as possible, I'll add them for KIDO 1.0.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. This is only relevant to the build system anyway; it doesn't impact the packaging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re: Packing. The ideal way to package KIDO as a Debian would be to create one
kido
source package thatBuild-Depend
s on the build dependencies all components. The source package would build a separate binary package for each component (e.g.kido-optimizer-nlopt
) thatDepend
s only on the runtime dependencies for the headers/library that it contains.I doubt it is possible to change this structure within one Debian release, since it changes the names (and number) of binary packages built from the source package.
Is this the plan? Or will we stick with a single, monolithic
kido
package for now?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand correctly, KIDO 0.1 is already doing exactly what you mentioned, and KIDO 0.1 and KIDO 1.0 will have same package structure.
Edit: You can check that the debian control file.