Updating the constraint namespace to C++11 #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to solve #583. At least in my case. Merge when ci is good. |
| { | ||
| // std::cout << "CommunityTEST::_containConstraint(): Not implemented." | ||
| // << std::endl; | ||
|
|
||
| // TODO(MXG): Is there any reason these functions are not implemented yet? |
There was a problem hiding this comment.
No reason. It seems I just forgot to implement. I'll implement them in a separate pull request soon.
|
👍 |
jslee02
added a commit
that referenced
this pull request
Jan 13, 2016
Updating the constraint namespace to C++11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is motivated by issue #583 where it was found that the
ConstraintSolverclass is leaking memory. Frequent deletion and creation ofWorldobjects can dramatically exacerbate the issue. By updating to use C++11 smart pointers, we should be able to eliminate these leaks.