Fix Visual Studio 2015 build errors #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'int': forcing value to bool 'true' or 'false'. Visual Studio 2015 won't allow the conversion from int to bool.
|
👍 |
jslee02
added a commit
that referenced
this pull request
Jan 8, 2016
Fix Visual Studio 2015 build errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes all the build errors that I encountered while trying to build DART with Visual Studio 2015.
CMake would fail to configure if you weren't using exactly Visual Studio 2013, so I added a conditional for 2015 as well.