add more hint to Pendulum.cpp, revise the typo error in collision.md #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Good catch. If @mxgrey approves, I think it's good to merge. |
|
wow! so efficient! I'm glad it is merged. |
|
This looks good to me 👍 |
jslee02
added a commit
that referenced
this pull request
Dec 24, 2015
add more hint to Pendulum.cpp, revise the typo error in collision.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some code in lesson 2a of Pendulum:
for(size_t i = 0; i < mPendulum->getNumDofs(); ++i)
{
DegreeOfFreedom* dof = mPendulum->getDof(i);
double q0 = dof->getRestPosition() + delta;
dof->setRestPosition(q0);
}
the variable delta may be the parameter of the functions, but the tutorial don't say where the variable 'delta' comes from.
http://dart.readthedocs.org/en/release-5.1/tutorials/multi-pendulum/#lesson-2a-set-joint-spring-rest-position
User may need read the finished file and get hints.
There is a typo error in collision.md