-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
End Effector, Inverse Kinematics, and OpenSceneGraph #461
Changes from 234 commits
18acc25
9494377
1c9e4a0
2bd1fac
ccb9706
b3b08ae
0b31f2e
2ff4c7e
645ca94
30cd5c2
0e96a4d
e10bbfc
ad701d5
5994f7d
bdf46cd
3741901
1534432
c9d6b4c
048af00
a5487b5
b200d3b
f31dddb
5f44b1f
1d2fdd9
f39b829
a9040a6
9bb263d
96ab0b0
179a995
6989b8f
122b011
5fbbb68
ba4a5fa
5da4071
d62c62e
7073caa
b8b0091
6af9cd0
5c9c20a
ad21cee
9bc26c9
44c7803
f5e8c7d
2a66009
1051440
164574f
d04b8ba
e4cab71
c297d12
5644214
5567391
ce3101b
57e23af
e0cf25c
63163c3
59e70f9
3455916
553c472
8a6f442
6b0266c
22042bd
17d4b4d
6038d2a
0686412
818d143
ccaf742
9583100
0a544e8
71abcba
994cbfc
ba60dbf
d918bae
d48b85a
b4fd8b8
84dde14
a92fd2a
8a614de
8f1757f
802199b
2241159
c26aef0
71f344d
e85d758
98321e9
2dfe757
b5d14f2
795d0b3
a4a4cbc
cf2210e
3439b1c
4e0c1f3
fe221c8
5bae0a7
877bb5b
af5eaf9
fb30636
9e1704f
682359d
d0d85f6
4152bf6
d1881ce
7ca39bb
0529d02
5358ebb
ec13db0
b2fe5d9
6f72a7d
c30a538
948fb44
259b0a4
7ed9107
f34af54
63db57e
8b0214f
3491785
57ac9b2
375a975
92c5a65
5c3faca
d17e8fe
a9de01f
59438c6
1d9f3b5
928341d
94c5387
394ce47
0df7db1
628e50f
cf035e7
0c9c844
a41438d
be68ccf
9907c8e
4493279
c9fd59d
2addca2
a0dffdd
3fd336d
780ba06
7881cd1
62a508d
e450038
cb75383
fc0932a
cb2b0f5
d9dc2d4
f90fc46
51e0473
ddbd0c7
3176c60
8ff3213
3657966
f8f7eb4
485a9d5
8812b53
7cf0081
c5abae5
7b41b1c
b9a53e7
7d119c0
741c7c2
2adfba1
2a00780
3fd1b8c
5211c76
4ec11f4
6398383
dbcc196
699f653
1219069
634f780
a5d1a50
20aed44
7be1bfb
7a540b8
993ea33
b36b183
0bf5b90
4ec7b44
6c92edd
7c4d37e
4bd5485
c824489
311dd68
56f4097
fe9ca94
ab8fc7e
886bc15
0ab5673
358628a
6768773
bb80cc5
76362cd
1e9da74
e252ebc
176d2b6
e99ef98
60c2f26
02cd362
a438b35
0fc5fc7
c39c4a7
b015f48
1328d61
2d0d43d
7ff8ac4
4923136
da2be6b
8c45640
cfee556
6d47a92
5e6440c
8aa6a5f
71de290
016117f
2ab3080
44a06f7
2997c9f
3e18fd3
1bb07e0
5ad6ad3
9b33c51
50e8788
6d6a818
9b45d90
018802f
ddfbed8
2683e16
6d093a6
bdb1d45
38da51e
7200dbe
ff28db1
0048e38
bcd7e36
23862c7
e7dec70
4180fdb
6f668af
a24ce02
7ea9c87
a3f323a
76b7a35
b975db2
41aeebd
ae2694b
97a623d
026ce86
bd9342e
68d5d27
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,6 +19,23 @@ set(DART_LIBRARY_DIRS "@CMAKE_INSTALL_PREFIX@/lib" "@Boost_LIBRARY_DIRS@") | |
|
||
include("${CURRENT_DIR}/DARTTargets.cmake") | ||
|
||
set(DART_LIBRARIES dart) | ||
find_library(dart_location NAMES "dart" PATHS "@CMAKE_INSTALL_PREFIX@/lib") | ||
set(DART_LIBRARIES "${dart_location}") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could we set There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
|
||
if(DART_FIND_COMPONENTS) | ||
foreach(comp ${DART_FIND_COMPONENTS}) | ||
find_library(dart_${comp}_location | ||
NAMES "dart-${comp}" | ||
PATHS "@CMAKE_INSTALL_PREFIX@/lib") | ||
if(dart_${comp}_location) | ||
list(APPEND DART_LIBRARIES "${dart_${comp}_location}") | ||
else() | ||
if(DART_FIND_REQUIRED_${comp}) | ||
message(FATAL_ERROR "dart-${comp} not available") | ||
endif(DART_FIND_REQUIRED_${comp}) | ||
endif(dart_${comp}_location) | ||
endforeach(comp) | ||
endif(DART_FIND_COMPONENTS) | ||
|
||
|
||
set(DART_VERSION @DART_VERSION@) |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,6 +35,8 @@ | |
* POSSIBILITY OF SUCH DAMAGE. | ||
*/ | ||
|
||
#define NOMINMAX | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We don't need this per #482. |
||
|
||
#include "dart/collision/fcl_mesh/FCLMeshCollisionDetector.h" | ||
|
||
#include <algorithm> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wouldn't work if DART is built in debug mode since the library name would contain appendix "d" (i.e.,
dartd
). I'm not sure we should care the case.Also, I haven't seen quotation mark is used for library name in find_library. Do we need it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good point. After looking into this a bit, it seems like the standard way to handle this would be to have two versions of the find_package macro: one for the release version and one for the debug version. That said, I'd be open to suggestions for other ways to have
find_package
distinguish between release and debug libraries.It looks like quotes in cmake are only really used to ensure that an argument with spaces in it does not get split into multiple arguments. That being the case, the quotes are probably worthless here.