Standardized warning messages for MultiDofJoints #425
Conversation
| dterr << "[MultiDofJoint::" #func "] mismatch beteween size of " \ | ||
| << #arg " [" << arg .size() << "] and the number of " \ | ||
| << "DOFs [" << getNumDofs() << "] for Joint named [" \ | ||
| << getName() << "]\n"; \ |
There was a problem hiding this comment.
Periods are omitted on purpose?
There was a problem hiding this comment.
I'm never really sure when to use periods in warning messages. I think usually if there is only one sentence for the whole message, I don't bother with a period, but I'll include periods if there are multiple sentences in the message.
That said, I have nothing against putting a period at the end.
There was a problem hiding this comment.
I agree. Sometimes it is not a sentence but just a word or a phrase.
How about putting a period at the end consistently?
There was a problem hiding this comment.
I guess if we enforce the use of complete sentences for warning messages (which would probably be good practice), then it would make sense to enforce ending those sentences with periods consistently. I'm on board.
There was a problem hiding this comment.
Sounds good. I will follow that rule. Please let me know if there are breaks in my future commits.
|
👍 |
|
Looks like appveyor needs a "retry". |
|
Appveyor has failed to build DART since 5 days ago. It seems to fail to install the dependencies of DART. I would not say this PR has something to do with it. I'm merging this PR and will make an separate issue for Appveyor. |
Standardized warning messages for MultiDofJoints
There was a lot of inconsistency among the format of warning messages for MultiDofJoint functions, even though the warnings they were giving were basically identical: indexing issues. This pull request standardizes (most of) them with two macros.