Implemented ArrowShape for visualizing arrows #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jslee02
added a commit
that referenced
this pull request
Mar 21, 2015
Implemented ArrowShape for visualizing arrows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created an ArrowShape which is just a specialization of the MeshShape.
This pull request also has constructors and destructors for aiScene, which allows us to delete aiScenes in the destructor of the MeshShape class. The only catch is that there is a
void* mPrivatein the aiScene structure which cannot be properly destructed without some hidden internal assimp data structures. It's probably worth raising an issue with the assimp retainers to understand why certain important constructors and destructors are not included in their basic library.