Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify minimum dependency versions on Linux #306

Merged
merged 12 commits into from
Jan 22, 2015

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Jan 21, 2015

This PR just makes it possible to specify minimum required dependency versions on Linux (since Windows does not support pkgconfig file), and remains determining the specific required dependency versions as future work. In order to do this, this pr:

  • Updates cmake find modules to be aware of installed version
  • Prints dependency version in the cmake output

Note that upper case module names will be used until migrate to cmake version that supports FOUND_VAR option for find_package_handle_standard_args.

This PR also passes DART version through DARTConfig.cmake and DARTCoreConfig.cmake so that it is able to print DART version in cmake process like:

  # Find DART
  find_package(DARTCore 4.1 QUIET)
  if (DARTCore_FOUND)
    message (STATUS "Looking for DARTCore - ${DART_VERSION} found")
  endif()

 - Update cmake find modules to be aware of installed version
 - Print dependency version in the cmake output
 - Pass DART version through DARTConfig.cmake and DARTCoreConfig.cmake
@jslee02 jslee02 added Comp: Build priority: low no timeline yet tag: feature request Indicates new feature requests labels Jan 21, 2015
@jslee02 jslee02 added this to the Release DART 5.0 milestone Jan 21, 2015
@jslee02 jslee02 changed the title Explicitly restric dependency versions Specify minimum dependency versions on Linux Jan 21, 2015
@jslee02 jslee02 modified the milestones: Release DART 4.3, Release DART 5.0 Jan 21, 2015
jslee02 added a commit that referenced this pull request Jan 22, 2015
Specify minimum dependency versions on Linux
@jslee02 jslee02 merged commit fbedb61 into master Jan 22, 2015
@jslee02 jslee02 deleted the dependency_version_display branch March 16, 2015 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low no timeline yet tag: feature request Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant