NameManager & const-correctness #277
Conversation
…Joints, and Markers (in Skeleton) and Skeletons (in World)
| @@ -0,0 +1,227 @@ | |||
| /* | |||
| * Copyright (c) 2011-2014, Georgia Tech Research Corporation | |||
There was a problem hiding this comment.
The copyright year should begin with the year of the file created. For this file, just 2014 would be good.
|
Ah woops, didn't realize the dates were per-file. Fixed. |
| mNameBeforeNumber(true), | ||
| mPrefix(""), mInfix("("), mAffix(")") {} | ||
|
|
||
| std::string mDefaultName; |
There was a problem hiding this comment.
Member variable should be a protected member with some comment.
There was a problem hiding this comment.
I actually left mDefaultName public on purpose, because there shouldn't be any negative consequences with the user having direct access to it. Is it a policy that absolutely all data members need to be wrapped in mutator/accessor functions?
There was a problem hiding this comment.
Yes, it's our convention that all data members need to be encapsulated.
There was a problem hiding this comment.
Understood; I'll be sure to enforce that in the future.
| @@ -624,9 +649,20 @@ class Skeleton | |||
|
|
|||
| /// List of body nodes in the skeleton. | |||
| std::vector<BodyNode*> mBodyNodes; | |||
| const std::string& addEntryToBodyNodeNameMgr(BodyNode* _newNode); | |||
There was a problem hiding this comment.
Group member variables and member functions separately
|
The requested changes have been made. I also altered the NameManager so that it exclusively manages pointers to objects. |
|
+1 |
NameManager & const-correctness
This commit contains a couple somewhat unrelated changes:
A NameManager class was created which has the ability to organize names of objects in a list and to generate new unique names if the user attempts to add an object with a name that is already being used.
The NameManager is being utilized by the World class to organize its Skeletons, and it's being used by the Skeleton class to organize its BodyNodes, SoftBodyNodes, Joints, and Markers.
This commit also contains const-correctness changes where accessor functions have been overloaded to offer a const version and a non-const version.
One final change was to create some consistency with out-of-bounds accessing behavior. Specifically, if the user requests an object from an index which is out-of-bounds, they will get back a NULL (which should probably be changed to "nullptr" in C++11 compatible versions of DART). This behavior already existed for many accessor functions, like Skeleton::getBodyNode(size_t), but it is now the standard for all other accessors, for example BodyNode::getCollisionShape(int).