Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Stopwatch class to replace Timer #1638

Merged
merged 1 commit into from
Dec 24, 2021
Merged

Add Stopwatch class to replace Timer #1638

merged 1 commit into from
Dec 24, 2021

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Dec 24, 2021


Before creating a pull request

  • Document new methods and classes
  • Format new code files using ClangFormat by running make format
  • Build with -DDART_TREAT_WARNINGS_AS_ERRORS=ON and resolve all the compile warnings

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.13.0 milestone Dec 24, 2021
@codecov
Copy link

codecov bot commented Dec 24, 2021

Codecov Report

Merging #1638 (bb5834b) into main (8eb7688) will increase coverage by 0.04%.
The diff coverage is 68.64%.

@@            Coverage Diff             @@
##             main    #1638      +/-   ##
==========================================
+ Coverage   58.96%   59.00%   +0.04%     
==========================================
  Files         485      488       +3     
  Lines       40272    40390     +118     
==========================================
+ Hits        23746    23832      +86     
- Misses      16526    16558      +32     
Impacted Files Coverage Δ
dart/common/Stopwatch.cpp 19.44% <19.44%> (ø)
dart/common/detail/Stopwatch-impl.hpp 86.66% <86.66%> (ø)
python/dartpy/common/Stopwatch.cpp 100.00% <100.00%> (ø)
python/dartpy/common/module.cpp 100.00% <100.00%> (ø)
dart/dynamics/EulerJoint.cpp 73.09% <0.00%> (+2.92%) ⬆️

@jslee02 jslee02 marked this pull request as ready for review December 24, 2021 07:10
@jslee02 jslee02 merged commit a07d7a9 into main Dec 24, 2021
@jslee02 jslee02 deleted the stopwatch branch December 24, 2021 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant