Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow SdfParser to set default root joint type #1617

Merged
merged 1 commit into from
Nov 1, 2021
Merged

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Oct 30, 2021


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.12.0 milestone Oct 30, 2021
@jslee02 jslee02 changed the title Add joint force/torque getter Allow SdfParser to set default root joint type Oct 30, 2021
@codecov
Copy link

codecov bot commented Oct 30, 2021

Codecov Report

Merging #1617 (49eb39f) into main (0cc469b) will increase coverage by 0.03%.
The diff coverage is 69.73%.

❗ Current head 49eb39f differs from pull request most recent head 92e3e73. Consider uploading reports for the commit 92e3e73 to get more accurate results

@@            Coverage Diff             @@
##             main    #1617      +/-   ##
==========================================
+ Coverage   59.06%   59.10%   +0.03%     
==========================================
  Files         477      477              
  Lines       39880    39938      +58     
==========================================
+ Hits        23556    23604      +48     
- Misses      16324    16334      +10     
Impacted Files Coverage Δ
dart/dynamics/Joint.hpp 100.00% <ø> (ø)
dart/utils/sdf/SdfParser.cpp 76.49% <62.16%> (-1.31%) ⬇️
dart/dynamics/Joint.cpp 59.03% <73.33%> (+3.05%) ⬆️
python/dartpy/utils/SdfParser.cpp 82.14% <79.16%> (+7.14%) ⬆️
dart/dynamics/EulerJoint.cpp 70.17% <0.00%> (-2.93%) ⬇️
dart/dynamics/ZeroDofJoint.cpp 27.66% <0.00%> (+4.85%) ⬆️

@jslee02 jslee02 force-pushed the sdf_parser_options branch from 49eb39f to 92e3e73 Compare November 1, 2021 14:34
@jslee02 jslee02 marked this pull request as ready for review November 1, 2021 14:35
@jslee02 jslee02 merged commit b663c87 into main Nov 1, 2021
@jslee02 jslee02 deleted the sdf_parser_options branch November 1, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant