Wrap IKFast solutions for cyclic joint positions #1452
Merged
+181
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IKFast sometimes returns solutions that are not wrapped within the range of the joint limits, which is regarded as an invalid solution in DART.
This PR fixes the issue by adding logic that tries to wrap IKFast solutions for rotational joints. The idea is to wrap the solution within joint limits. If there is more than one solution (when the joint limit range is wider than 2pi), it returns the closest solution to the current joint position to minimize joint motion.
The logic should be applied to any DegreeOfFreedom whose configuration space is SO(2), but this PR only applies it to RevoluteJoint. This is because the current API doesn't provide for it.
DegreeOfFreedom::isCyclic()
is the closest function to what we want, but it only returns true when the rotational joint has no limits.This PR partially fix #1449 because it only works for
RevoluteJoint
.Before creating a pull request
clang-format
Before merging a pull request
CHANGELOG.md