Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ConeShape support for FCLCollisionDetector #1447

Merged
merged 3 commits into from
Apr 22, 2020
Merged

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Apr 22, 2020

The sphere was used for ConeShape when FCLCollisionDetector is used. This PR changed to use mesh for ConeShape as other shapes in FCLCollisionDetector.


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.10.0 milestone Apr 22, 2020
@codecov
Copy link

codecov bot commented Apr 22, 2020

Codecov Report

Merging #1447 into master will increase coverage by 0.19%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master    #1447      +/-   ##
==========================================
+ Coverage   57.99%   58.18%   +0.19%     
==========================================
  Files         412      412              
  Lines       29861    29875      +14     
==========================================
+ Hits        17319    17384      +65     
+ Misses      12542    12491      -51     
Impacted Files Coverage Δ
dart/collision/fcl/BackwardCompatibility.hpp 0.00% <ø> (ø)
dart/collision/fcl/FCLCollisionDetector.cpp 89.63% <71.42%> (+7.44%) ⬆️
dart/dynamics/Skeleton.cpp 66.33% <0.00%> (+0.16%) ⬆️
dart/dynamics/ConeShape.cpp 48.83% <0.00%> (+9.30%) ⬆️
dart/collision/fcl/BackwardCompatibility.cpp 87.50% <0.00%> (+12.50%) ⬆️

mxgrey
mxgrey previously approved these changes Apr 22, 2020
@jslee02 jslee02 merged commit 9cfc3f6 into master Apr 22, 2020
@jslee02 jslee02 deleted the fcl_cone_support branch April 22, 2020 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants