Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modifier key support to ImGuiHandler #1436

Merged
merged 3 commits into from
Feb 27, 2020
Merged

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Feb 26, 2020

This PR fixes that modifier keys were not correctly hooked for ImGuiHandler.


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • [N/A] Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.10.0 milestone Feb 26, 2020
@jslee02 jslee02 changed the title Add modifier key support to ImGuiHander Add modifier key support to ImGuiHandler Feb 26, 2020
@jslee02 jslee02 marked this pull request as ready for review February 26, 2020 16:28
@codecov
Copy link

codecov bot commented Feb 26, 2020

Codecov Report

Merging #1436 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1436      +/-   ##
==========================================
+ Coverage   57.98%   58.00%   +0.02%     
==========================================
  Files         412      412              
  Lines       29861    29861              
==========================================
+ Hits        17316    17322       +6     
+ Misses      12545    12539       -6     
Impacted Files Coverage Δ
dart/dynamics/EulerJoint.cpp 73.00% <0.00%> (+3.68%) ⬆️

@jslee02 jslee02 merged commit febad10 into master Feb 27, 2020
@jslee02 jslee02 deleted the imgui_modifier_keys branch February 27, 2020 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant