Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of boost::filesystem in public APIs #1417

Merged
merged 3 commits into from
Sep 20, 2019
Merged

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Sep 20, 2019


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.10.0 milestone Sep 20, 2019
@codecov
Copy link

codecov bot commented Sep 20, 2019

Codecov Report

Merging #1417 into master will decrease coverage by 0.01%.
The diff coverage is 58.82%.

@@            Coverage Diff            @@
##           master   #1417      +/-   ##
=========================================
- Coverage   57.22%   57.2%   -0.02%     
=========================================
  Files         367     367              
  Lines       27568   27574       +6     
=========================================
- Hits        15775   15773       -2     
- Misses      11793   11801       +8
Impacted Files Coverage Δ
dart/common/detail/SharedLibraryManager.hpp 100% <ø> (ø) ⬆️
dart/common/SharedLibrary.cpp 51.42% <44.44%> (-10.65%) ⬇️
dart/common/detail/SharedLibraryManager.cpp 68.18% <75%> (-6.82%) ⬇️

@jslee02 jslee02 merged commit 18bff8e into master Sep 20, 2019
@jslee02 jslee02 deleted the remove_boost_filesystem branch September 20, 2019 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant