Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type property to constraint classes #1415

Merged
merged 4 commits into from
Sep 16, 2019
Merged

Add type property to constraint classes #1415

merged 4 commits into from
Sep 16, 2019

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Sep 15, 2019


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.10.0 milestone Sep 15, 2019
@jslee02 jslee02 marked this pull request as ready for review September 15, 2019 20:30
@codecov
Copy link

codecov bot commented Sep 15, 2019

Codecov Report

Merging #1415 into master will decrease coverage by 0.09%.
The diff coverage is 17.85%.

@@            Coverage Diff            @@
##           master    #1415     +/-   ##
=========================================
- Coverage   57.31%   57.22%   -0.1%     
=========================================
  Files         367      367             
  Lines       27521    27568     +47     
=========================================
+ Hits        15774    15775      +1     
- Misses      11747    11793     +46
Impacted Files Coverage Δ
dart/constraint/BallJointConstraint.hpp 0% <ø> (ø) ⬆️
dart/constraint/WeldJointConstraint.hpp 0% <ø> (ø) ⬆️
dart/constraint/ContactConstraint.hpp 100% <ø> (ø) ⬆️
dart/constraint/JointLimitConstraint.hpp 100% <ø> (ø) ⬆️
dart/constraint/JointLimitConstraint.cpp 69.69% <0%> (-1.81%) ⬇️
dart/constraint/ServoMotorConstraint.cpp 78.94% <0%> (-3.63%) ⬇️
dart/constraint/MimicMotorConstraint.cpp 80.32% <0%> (-3.44%) ⬇️
dart/constraint/BallJointConstraint.cpp 9.19% <0%> (-0.28%) ⬇️
dart/constraint/SoftContactConstraint.cpp 0% <0%> (ø) ⬆️
dart/constraint/JointCoulombFrictionConstraint.cpp 81.57% <0%> (-3.75%) ⬇️
... and 4 more

@jslee02 jslee02 merged commit 69b4fd4 into master Sep 16, 2019
@jslee02 jslee02 deleted the constraint_type branch September 16, 2019 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant