Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dartpy] Remove static create() functions in favor of custom custructors #1324

Merged
merged 6 commits into from
May 19, 2019

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented May 19, 2019

API changes:

import dartpy as dart

# Before
world = dart.simulation.World.create()
skel = dart.dynamics.Skeleton.create()
world.addSkeleton(skel)
chain = dart.dynamics.Chain(shoulder, elbow, dart.dynamics.Chain.IncludeUpstreamParentJointTag.IncludeUpstreamParentJoint)

# After
world = dart.simulation.World()
skel = dart.dynamics.Skeleton()
world.addSkeleton(skel)
chain = dart.dynamics.Chain(shoulder, elbow, True)  # or chain = dart.dynamics.Chain(shoulder, elbow, includeUpstreamParentJoint=True)

Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.9.0 milestone May 19, 2019
@jslee02 jslee02 marked this pull request as ready for review May 19, 2019 01:59
@codecov
Copy link

codecov bot commented May 19, 2019

Codecov Report

Merging #1324 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1324   +/-   ##
=======================================
  Coverage   57.12%   57.12%           
=======================================
  Files         366      366           
  Lines       27050    27050           
=======================================
  Hits        15452    15452           
  Misses      11598    11598

@jslee02 jslee02 merged commit 5e6eb55 into master May 19, 2019
@jslee02 jslee02 deleted the dartpy/remove_create branch May 19, 2019 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant