Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use URDF material color when specified #1295

Merged
merged 5 commits into from
Apr 29, 2019
Merged

Use URDF material color when specified #1295

merged 5 commits into from
Apr 29, 2019

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Apr 28, 2019 •
edited
Loading

URDF parser always uses material color defined in mesh file even when color is defined in the URDF file. This PR changes the behavior to use the color defined in URDF when specified.

Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.9.0 milestone Apr 28, 2019
@jslee02 jslee02 merged commit 1fc6d26 into master Apr 29, 2019
@jslee02 jslee02 deleted the urdf_color_override branch April 29, 2019 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxgrey mxgrey mxgrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
DART 6.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jslee02 @mxgrey