Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix not defining boost targets #1254

Merged
merged 3 commits into from
Feb 23, 2019
Merged

Fix not defining boost targets #1254

merged 3 commits into from
Feb 23, 2019

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Feb 23, 2019 •
edited
Loading

This allows us to use the boost targets even when the default FindBoost.cmake doesn't define imported boost targets.

Before creating a pull request

  • Document new methods and classes (N/A)
  • Format new code files using clang-format (N/A)

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change (N/A)

@jslee02 jslee02 added this to the DART 6.8.0 milestone Feb 23, 2019
@jslee02 jslee02 changed the title Define imported boost targets when not defined Fix not defining boost targets when not defined Feb 23, 2019
@jslee02 jslee02 changed the title Fix not defining boost targets when not defined Fix not defining boost targets Feb 23, 2019
@jslee02 jslee02 merged commit e37fef5 into master Feb 23, 2019
@jslee02 jslee02 deleted the boost branch February 23, 2019 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
DART 6.8.0
Development

Successfully merging this pull request may close these issues.
1 participant
@jslee02