Fail to find a component if one of its external dependencies is missing #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this was committed on top of #1222, so that one should be reviewed and merged before this one. |
jslee02
reviewed
Jan 11, 2019
jslee02
previously approved these changes
Jan 14, 2019
There was a problem hiding this comment.
This solution looks much cleaner than my suggestion in #1209! Besides the nitpick, looks good to go!
jslee02
approved these changes
Jan 14, 2019
…m/dartsim/dart into grey/fail_config_when_dep_missing
mxgrey
added a commit
that referenced
this pull request
Jan 16, 2019
jslee02
pushed a commit
that referenced
this pull request
Jan 17, 2019
There's a case where the changes in #1223 fail if dependent components are requested. For example, if you ask for ``` find_package(DART COMPONENTS utils utils-urdf) ``` then the build system can get confused about whether or not the component and its dependencies were properly found. We fix that in this PR by moving the location where the `TRUE` assumption is made.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the conversation at the bottom of #1222: If an external dependency of a component is missing, then the component will be declared as "not found", which should create a configuration error when that component is required.
Before creating a pull request
clang-formatBefore merging a pull request
CHANGELOG.md