Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change BoxedLcpConstraintSolver to use Eigen instead of raw pointer #1101

Merged
merged 14 commits into from
Aug 24, 2018

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Aug 14, 2018

Summary of Changes

  • Use Eigen objects instead of raw point in BoxedLcpConstraintSolver
  • Assume ContactConstraint handles only one contact
  • Make LCP related terms as member variable to avoid frequent memory allocation
  • Format code of BoxedLcpConstraintSolver and ContactConstraint

Depends on #1099


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md

@jslee02 jslee02 added this to the DART 6.7.0 milestone Aug 14, 2018
@jslee02 jslee02 requested a review from mxgrey August 14, 2018 05:54
@codecov
Copy link

codecov bot commented Aug 14, 2018

Codecov Report

Merging #1101 into release-6.7 will decrease coverage by 0.02%.
The diff coverage is 66.43%.

@@               Coverage Diff               @@
##           release-6.7    #1101      +/-   ##
===============================================
- Coverage        56.33%   56.31%   -0.03%     
===============================================
  Files              327      328       +1     
  Lines            24811    24793      -18     
===============================================
- Hits             13978    13962      -16     
+ Misses           10833    10831       -2
Impacted Files Coverage Δ
dart/constraint/BoxedLcpConstraintSolver.hpp 100% <ø> (ø) ⬆️
...art/dynamics/detail/TranslationalJoint2DAspect.hpp 60% <ø> (ø) ⬆️
dart/common/detail/LockableReference-impl.hpp 36.36% <0%> (+1.06%) ⬆️
dart/constraint/ContactConstraint.hpp 100% <100%> (ø)
dart/constraint/ContactConstraint.cpp 61.53% <64.43%> (+0.12%) ⬆️
dart/constraint/BoxedLcpConstraintSolver.cpp 51.82% <77.77%> (-4.82%) ⬇️

…or_contact_constraint

# Conflicts:
#	dart/constraint/BoxedLcpConstraintSolver.cpp
#	dart/constraint/BoxedLcpConstraintSolver.hpp
#	dart/constraint/CMakeLists.txt
#	examples/osgExamples/osgBoxStacking/osgBoxStacking.cpp
@jslee02 jslee02 merged commit 3698fcf into release-6.7 Aug 24, 2018
@jslee02 jslee02 deleted the enhance/refactor_contact_constraint branch August 24, 2018 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant