Final step to give dartsim stable status in ROS build farm #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I kind of wish it were possible to rebase pull requests 😅 |
jslee02
approved these changes
Mar 14, 2018
|
@mxgrey It's enabled now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for all the PR spam, but we're almost there! The last thing the ROS package build farm is complaining about is a cmake warning that we expect to occur. This results in an "unstable" status, which is acceptable, but I'd prefer we make it stable since it's such an easy fix (and this should probably be a status message instead of a warning anyway).
I also updated the changelog to include PR #1032 which I accidentally skipped.