Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing package name of FCL and removing libccd in package.xml #1029

Merged
merged 3 commits into from
Mar 13, 2018

Conversation

mxgrey
Copy link
Member

@mxgrey mxgrey commented Mar 13, 2018

After running some experiments with the ROS release tools, it seems they expect the package name for fcl to be libfcl-dev, and libccd doesn't seem to be recognized as a package (but we only depend on it transitively through libfcl, so it shouldn't matter).

This version of the package.xml seemed to work with bloom-release.

Copy link
Member

@jslee02 jslee02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, this is for DART 6.3.2, right?

@mxgrey
Copy link
Member Author

mxgrey commented Mar 13, 2018

I'm going to say that the last "release" of 6.3.1 was a dud. I marked it as a prerelease anyhow, and it's deleted now since it didn't work.

@mxgrey
Copy link
Member Author

mxgrey commented Mar 13, 2018

By the way, if deleting a release like that causes issues with any kind of automated release procedure that I don't know about, let me know and I'll refrain from doing that in the future.

@jslee02
Copy link
Member

jslee02 commented Mar 13, 2018

We don't have any automated release procedure, but I think it would be preferable to increase patch number with a fix if we already tagged to avoid any possible issues.

@mxgrey
Copy link
Member Author

mxgrey commented Mar 13, 2018

I also deleted the tag already 😅

@mxgrey
Copy link
Member Author

mxgrey commented Mar 13, 2018

Does this plan sound okay:

To move to the next stage of trying to release DART into ROS, I'll create a new tagged release of 6.3.1 which is explicitly marked on GitHub as a prerelease. That should allow us to submit a PR to get DART released into ROS, and allow the ROS maintainers to test the release of 6.3.1.

If the tests fail on the ROS end (e.g. our package.xml is missing some important dependency), then we can make the necessary changes, delete the prerelease tag of 6.3.1, tag the new commit as v6.3.1, and ask the ROS maintainers to try it again.

Once v6.3.1 is working correctly on the ROS build farm, we'll promote it from a prerelease to an actual release.

I think this would be the easiest procedure for both us and the ROS maintainers, if it sounds okay to you.

@jslee02
Copy link
Member

jslee02 commented Mar 13, 2018

That sounds perfect to me! Otherwise, we would end up increasing N patches whenever we find failures on the ROS end.

@codecov
Copy link

codecov bot commented Mar 13, 2018

Codecov Report

Merging #1029 into release-6.3 will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           release-6.3    #1029   +/-   ##
============================================
  Coverage        56.22%   56.22%           
============================================
  Files              300      300           
  Lines            23548    23548           
============================================
  Hits             13239    13239           
  Misses           10309    10309

@mxgrey mxgrey merged commit 3afb966 into release-6.3 Mar 13, 2018
@jslee02 jslee02 added this to the DART 6.3.1 milestone Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants