-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing package name of FCL and removing libccd in package.xml #1029
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably, this is for DART 6.3.2, right?
I'm going to say that the last "release" of 6.3.1 was a dud. I marked it as a prerelease anyhow, and it's deleted now since it didn't work. |
By the way, if deleting a release like that causes issues with any kind of automated release procedure that I don't know about, let me know and I'll refrain from doing that in the future. |
We don't have any automated release procedure, but I think it would be preferable to increase patch number with a fix if we already tagged to avoid any possible issues. |
I also deleted the tag already 😅 |
Does this plan sound okay: To move to the next stage of trying to release DART into ROS, I'll create a new tagged release of 6.3.1 which is explicitly marked on GitHub as a prerelease. That should allow us to submit a PR to get DART released into ROS, and allow the ROS maintainers to test the release of 6.3.1. If the tests fail on the ROS end (e.g. our Once v6.3.1 is working correctly on the ROS build farm, we'll promote it from a prerelease to an actual release. I think this would be the easiest procedure for both us and the ROS maintainers, if it sounds okay to you. |
That sounds perfect to me! Otherwise, we would end up increasing N patches whenever we find failures on the ROS end. |
Codecov Report
@@ Coverage Diff @@
## release-6.3 #1029 +/- ##
============================================
Coverage 56.22% 56.22%
============================================
Files 300 300
Lines 23548 23548
============================================
Hits 13239 13239
Misses 10309 10309 |
After running some experiments with the ROS release tools, it seems they expect the package name for fcl to be
libfcl-dev
, andlibccd
doesn't seem to be recognized as a package (but we only depend on it transitively throughlibfcl
, so it shouldn't matter).This version of the package.xml seemed to work with
bloom-release
.